Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPUBackend: Fix Depth Buffer #26395

Merged
merged 3 commits into from
Jul 9, 2023
Merged

WebGPUBackend: Fix Depth Buffer #26395

merged 3 commits into from
Jul 9, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 8, 2023

Related issue: Fixes #26381

Description

Fix the use of the same Depth Buffer used in different RenderContext.

@sunag sunag added this to the r155 milestone Jul 8, 2023
@sunag sunag marked this pull request as ready for review July 9, 2023 01:47
@sunag sunag merged commit d7edc95 into mrdoob:dev Jul 9, 2023
const { width, height } = this.getDrawingBufferSize();

let depthTexture = depthBuffers.get( renderContext );
const depthTexture = this.defaultDepthTexture;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clone it here? Or is this unneeded?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unneeded... I thought to add a cache to stencil/depth variations soon if needed too.

@sunag sunag deleted the dev-depthbuffer branch July 12, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPURenderer depth/stencil buffer duplication/confusion
2 participants