OculusHandPointerModel: Make _onDisconnected() more robust.
#26387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng connected to a hand before.
|
Minor clean up: 95fbc39 |
Mugen87
changed the title
_onDisconnected() more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Description
In applications supporting both hands and controllers, and dynamic switching between them, it's quite common to create a hand pointer model early on even if no hand is connected at that point.
Using controllers will then cause the connected event to fire, no hand model being created (because the connected thing is not a hand) but then on session exit the current code tries to dispose the non-existant hand and pointer model.
This PR just checks if they exist before disposing them. cc @CodyJasonBennett
This contribution is funded by Needle