Improved performance of Unreal Bloom example. #26356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented pre-calculated Gaussian coefficients in shader.
keaukraine
force-pushed
the
faster-unreal-bloom
branch
from
0c0ad32 to
11a01ca
Compare
LeviPesin
reviewed
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented pre-calculated Gaussian coefficients in shader for Unreal Bloom example.
Related issue: None.
Description
I've noticed that fragment shader for blur calculates Gaussian coefficients which uses quite expensive math.
I moved these coefficients to a pre-computed uniform array which eliminated most of math in shader.
Additionally, simplified math for texture fetch - passing reciprocal of texture size instead of calculating it per fragment.
Visually there is no difference between the old and new shaders - math is kept intact, only offloaded from GPU to CPU.