WebGPURenderer: Remove duplication of interleaved attribute buffers. #26351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
June 9, 2023 10:07
LeviPesin
reviewed
Jun 29, 2023
LeviPesin
reviewed
Jun 29, 2023
LeviPesin
reviewed
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associate attribute GPUBuffers with interleaved attributes' common shared buffer instead of the attribute itself to remove the duplication of GPUBuffers.
Rework vertex buffer layout for the pipeline to remove duplicate buffer entries, and setVertexBuffer() calls to match the new layout.
Rework nodes InstanceNode and BufferAttributeNode to use shared backing buffers for conversion of mat4 to vec4 * 4.
(required to ensure the backing buffer is of the correct type)