Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: UVEditor revision and remove nodes for programmers #26345

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jun 28, 2023

Description

UVEditor revision and remove nodes for programmers from the graphic.

@sunag sunag added this to the r154 milestone Jun 28, 2023
@sunag sunag merged commit c141369 into mrdoob:dev Jun 28, 2023
@@ -12,7 +12,9 @@ export class UVEditor extends BaseNodeEditor {

this.setOutputLength( 2 );

const optionsField = new SelectInput( [ '1', '2' ], 0 ).onChange( () => {
const options = Array.from( Array( 4 ).keys() ).map( String );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think [ '0', '1', '2', '3' ] is much more readable.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I was supposed to be customized, but I ended up removing that option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants