WebGPURenderer: Render Pass ID and Double Pass #26333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Jun 27, 2023
|
|
||
| } else { | ||
|
|
||
| this._renderObjectDirect( object, scene, camera, geometry, material, group, lightsNode ); |
There was a problem hiding this comment.
Maybe we should here also use frontSide or backSide namespace depending on material side? Not sure if I understood the namespaces approach correctly...
There was a problem hiding this comment.
Namespace can cause confusion, I renamed the term to pass id, seems more appropriate. It is compared with a parameter in chain map to get a unique RenderObject:
const renderObject = this._objects.get( object, material, scene, camera, lightsNode, passId )
...
return chainMaps[ passId ].get( object, material, scene, camera, lightsNode );
sunag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RenderObjectspass idis useful to renderer the same object with internal modifications without needs to usematerial.needsUpdateand preserving the chain map.Added support for
forceSinglePass = falsehttps://raw.githack.com/sunag/three.js/dev-ns/examples/webgpu_backdrop_area.html