ArcballControls: Add rotateSpeed.
#26332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begmec
changed the title
|
LGTM! Do you mind updating the documentation page? https://threejs.org/docs/index.html#examples/en/controls/ArcballControls You can essentially copy/paste the description of |
- lexically sort documented properties
Mugen87
approved these changes
Jun 27, 2023
Mugen87
changed the title
rotateSpeed.
|
Thanks @Mugen87 ! |
This was referenced Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The user wants to set the rotational speed for the arcball controls. Currently it is fix and cannot be set. Similar to the orbit controls, I added a "rotateSpeed" option that lets you define a speed factor.