Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Sheen #26329

Merged
merged 5 commits into from
Jun 26, 2023
Merged

WebGPURenderer: Sheen #26329

merged 5 commits into from
Jun 26, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jun 26, 2023

@sunag sunag added this to the r154 milestone Jun 26, 2023
@sunag sunag marked this pull request as ready for review June 26, 2023 07:10
LeviPesin
LeviPesin reviewed Jun 26, 2023
View reviewed changes
examples/jsm/nodes/accessors/MaterialNode.js

}

node = node.clamp( 0.07, 1.0 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the minimum is 0.7?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that 0.07 is to prevent incompatible values.

three.js/src/renderers/shaders/ShaderChunk/lights_physical_fragment.glsl.js

Line 111 in cdfefb4

material.sheenRoughness = clamp( sheenRoughness, 0.07, 1.0 );

LeviPesin
LeviPesin reviewed Jun 26, 2023
View reviewed changes
examples/jsm/nodes/core/NodeBuilder.js
@@ -43,13 +43,14 @@ const toFloat = ( value ) => {

class NodeBuilder {

constructor( object, renderer, parser ) {
constructor( object, renderer, parser, scene = null ) {
Copy link
Contributor

@LeviPesin LeviPesin Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for scene we can use an approach like for CameraNode or ObjectNode -- taking the value from frame updates?

Copy link
Collaborator Author

@sunag sunag Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... Using this approach, we can try soon create sceneBackground (or just background), it can change the code if scene.background is different, the same not happen with per frame approach.

@sunag sunag merged commit b621f0e into mrdoob:dev Jun 26, 2023
@sunag sunag deleted the dev-webgpu-sheen branch June 27, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeviPesin LeviPesin LeviPesin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r154
Development

Successfully merging this pull request may close these issues.
2 participants
@sunag @LeviPesin