WebGLRenderer: Fix shadow update when object is culled. #26293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
changed the title
Mugen87
reviewed
Jun 20, 2023
| @@ -1093,6 +1093,9 @@ class WebGLRenderer { | |||
|
|
|||
| const shadowsArray = currentRenderState.state.shadowsArray; | |||
|
|
|||
| // muse be done before shadowMap.render, so that the number is the the same for shadows and real objects | |||
| this.info.render.frame ++; | |||
There was a problem hiding this comment.
I think this was an important fix since it potentially produced general frame late effects when rendering the shadow map (because WebGLShadowMap.render() relied on an outdated frame value).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26292
Description
Update of the skeleton needs to be called whenever the object or its shadow are rendered. The update is optimized to be done only once per frame already, one just needs to be careful to have the rendered frame index updated at the right moment.
I have an updated bones-browser.html demonstrating the issue, however I am not sure if (and how) I should include it in this PR.