Nodes: Fix VideoTexture in WebGPUBackend & ColorSpaceNode revision #26261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Jun 14, 2023
| return builder.format( propertyName, nodeType, output ); | ||
| let snippet = propertyName; | ||
|
|
||
| if ( builder.needsColorSpace( this.value ) ) { |
There was a problem hiding this comment.
I think we should name this method something like needsForceLinear or needsConversionToLinear?
There was a problem hiding this comment.
Hmm.. Maybe needsColorConversionToLinear
LeviPesin
reviewed
Jun 14, 2023
|
|
||
| export default ColorSpaceNode; | ||
|
|
||
| export const colorSpace = ( node, colorSpace ) => nodeObject( new ColorSpaceNode( null, nodeObject( node ) ).fromColorSpace( colorSpace ) ); | ||
| export const linearToColorSpace = ( node, colorSpace ) => nodeObject( new ColorSpaceNode( getMethod( LinearSRGBColorSpace, colorSpace ), nodeObject( node ) ) ); |
There was a problem hiding this comment.
Maybe just toColorSpace and fromColorSpace?
There was a problem hiding this comment.
I think it's is not possible currently. We need to know what the source is to made the conversion properly.
Merged
This was referenced Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26233
Description
Related: #26233 (comment)