PLYLoader: Fix handling binary files with \n\r line endings in header. #26232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 9, 2023 10:07
Mugen87
changed the title
Mugen87
approved these changes
Jun 12, 2023
GitHubDragonFly
added a commit
to GitHubDragonFly/GitHubDragonFly.github.io
that referenced
this pull request
Jun 12, 2023
- It includes all updates as well as mrdoob/three.js#26232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #26229
Header length calculations were carried out after \n characters were removed from the header text hence the file offset for reading binary data was incorrect.
Detect type of line ending for first line, and get header length in extractHeaderText() function instead of in parseHeader().
The header length is only required in binary format files.