Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeMaterial: Fix default forceSinglePass & .alphaMap #26231

Merged
merged 1 commit into from
Jun 10, 2023
Merged

NodeMaterial: Fix default forceSinglePass & .alphaMap #26231

merged 1 commit into from
Jun 10, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jun 10, 2023

Related issue: https://discourse.threejs.org/t/node-materials-incompatibility-with-regular-materials/52589

Description

Fix forceSinglePass = false as default.
Fix alphaMap if opacityNode is not used.

@sunag sunag marked this pull request as ready for review June 10, 2023 13:58
@sunag sunag merged commit c8075f5 into mrdoob:dev Jun 10, 2023
@sunag sunag deleted the dev-fix-alphaMap branch June 10, 2023 14:03
@mrdoob mrdoob added this to the r154 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r154
Development

Successfully merging this pull request may close these issues.
2 participants
@sunag @mrdoob