-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MeshSurfaceSampler: Add uv
support.
#26207
Conversation
uv
support.
At some point this function should really just return a barycoord value and face index so users can interpolate between whatever buffer attributes they want to. Adding a new argument for every possible buffer attribute doesn't seem sustainable 😅 |
I'm afraid not all users know how to do the interpolation correctly. Maybe better when |
Maybe we can add another method that does just that (i.e. returns barycoords and index)? So we can have both. |
Adding that method (
|
Oh I did not see 24629. Maybe I could borrow the docs thing from there 🤔 |
that's weird, I did add the commit by @IanSweeneyAC but it does not appear in this PR... edit: so I was hit by this |
and now there is failed webxr_vr_sandbox screenshot. not my fault, lol |
Don't worry about this example. It frequently fails in other PRs, too. Maybe regenerating the screenshots would help. |
Maybe we should add that example to the exceptions? (The number of exceptions starts to be really large... I should look into it and see what can be fixed (e.g. setIntervals), also need to remove BrowserFetcher for Puppeteer 20) |
this is one of two changes I had to do to MeshSurfaceSampler in order to use it for the grass effect - let's see if it makes sense to you, and then I will maybe come back with the other one