Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAARenderPass: Fix color shift. #26199

Merged
merged 1 commit into from
Jun 7, 2023
Merged

TAARenderPass: Fix color shift. #26199

merged 1 commit into from
Jun 7, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 6, 2023

Fixed #24318.

Description

This PR should finally fix the color shift during the accumulation phase of TAARenderPass.

@Mugen87 Mugen87 marked this pull request as ready for review June 6, 2023 09:00
@@ -133,7 +133,6 @@ class TAARenderPass extends SSAARenderPass {
this.copyUniforms[ 'opacity' ].value = 1.0 - accumulationWeight;
this.copyUniforms[ 'tDiffuse' ].value = this.holdRenderTarget.texture;
renderer.setRenderTarget( writeBuffer );
if ( accumulationWeight === 0 ) renderer.clear();
Copy link
Collaborator Author

@Mugen87 Mugen87 Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was this clear operation. When it happens, it deletes the contents of the previous render which explains the flash at the beginning of the accumulation phase.

@Mugen87 Mugen87 added this to the r154 milestone Jun 6, 2023
@Mugen87 Mugen87 merged commit 84d625d into mrdoob:dev Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TAARenderPass: Pass over-brightens scene, shows occasional black frames
1 participant