-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppeteer E2E test: Use new
headless mode
#25982
Conversation
Reposting my comment from #25979
|
Wouldn't that confuse people if they try to (re)generate screenshot on their machine and then after commiting it see that it doesn't work because it renders differently on Linux? Currently we can see which screenshots render differently on which OSes. |
I guess we have to pick one...
|
The MacOS is the worst OS for running CI tests -- currently Mac tests sometimes don't complete even in 20 minutes. If we are going to select one it's better to return to the Ubuntu. |
Does any of them support WebGPU yet? 🤔 |
Chrome 113 supported WebGPU by default, I tested it can generated screenshot with WebGPU examples in my computer (windows 11) with I tried commit this code in my repo to test, but it has some fail... TBH, I have no idea how to fix it. P.S. |
I think the problem is not that Chrome doesn't support WebGPU (it does behind a flag) but that Chrome headless mode doesn't. Maybe in this new mode which should be more similar to headful it would... |
To clarify: Since 113 enabling a flag isn't necessary anymore. WebGPU works right out of the box. |
Can we merge this PR? I plan again to work on E2E (replacing BrowserFetcher with |
Okay! |
Related issue: #25979
(I cannot access my computer currently to do a force push so I just created a new branch from an older commit and made new PR)