Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMDLoader: Catch parser exceptions. #25966

Merged

Conversation

YusakuNo1
Copy link
Contributor

Description

In MMDLoader, the exceptions from mmd-parser are not sent onError function, for example, this is one exception from mmd-parser: https://github.com/takahirox/mmd-parser/blob/master/src/Parser.js#L523 . This PR resends all the errors to onError function

Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks for improving error handling in MMDLoader.

@Mugen87 Mugen87 added this to the r153 milestone May 1, 2023
@Mugen87 Mugen87 merged commit c25f9a5 into mrdoob:dev May 1, 2023
@Mugen87 Mugen87 changed the title Catch parser exceptions in MMDLoader MMDLoader: Catch parser exceptions. May 1, 2023
GitHubDragonFly added a commit to GitHubDragonFly/GitHubDragonFly.github.io that referenced this pull request May 1, 2023
- Catch parser errors as per mrdoob/three.js#25966
@YusakuNo1 YusakuNo1 deleted the users/yusakuno1/catch-mmdloader-exceptions branch May 2, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants