Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Texture URI as name. #25664

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Mar 13, 2023

Description

Assumes a URI as the name if the other options are not available.

Example getting from DamagedHelmet.gltf file:

image

/ping @donmccurdy @Mugen87

@Mugen87 Mugen87 added this to the r151 milestone Mar 13, 2023
@Mugen87 Mugen87 merged commit b9002a8 into mrdoob:dev Mar 13, 2023
@sunag sunag deleted the dev-gltf-texture-uri branch March 13, 2023 08:40
@takahirox
Copy link
Collaborator

takahirox commented Mar 14, 2023

I think texture uri can be data URI so using texture uri as texture name only if it isn't data URI would be good because data URI may be meaningless and can be too long as a name?

@takahirox
Copy link
Collaborator

@sunag Would you want to make a PR if my suggestion sounds good? If you are too busy, I can make.

@sunag
Copy link
Collaborator Author

sunag commented Mar 15, 2023

Hi @takahirox, your suggestion is very important. I would like to understand better how this data is stored. Would you have a file with data URI for me to check?

@takahirox
Copy link
Collaborator

takahirox commented Mar 15, 2023

I think you can just check the uri starts with data:image/.

https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#images
https://en.wikipedia.org/wiki/Data_URI_scheme

But yes you may need a file for test. Unfortunately I don't have it right now. @donmccurdy Do you have it?

@donmccurdy
Copy link
Collaborator

Here's a simple example:

BoxTextured.gltf.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants