Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferGeometryUtils: Simplify function names #25652

Merged
merged 4 commits into from
Mar 11, 2023

Conversation

WestLangley
Copy link
Collaborator

BufferGeometryUtils.interleaveAttributes() exists, so the following changes are consistent with current nomenclature:

mergeBufferGeometries() -> mergeGeometries()
mergeBufferAttributes() -> mergeAttributes()

@WestLangley WestLangley added this to the r151 milestone Mar 11, 2023
@WestLangley
Copy link
Collaborator Author

I will do necessary clean-up of warnings in a follow-on PR.

@Benjythebee
Copy link
Contributor

When this PR was merged, it should have been followed up with a @deprecated use '...' flag on the previous name functions;
Without the flag, a dev can end up super confused why his/her IDE is screaming "function does not exists" when updating Three

@WestLangley
Copy link
Collaborator Author

@Benjythebee

The deprecation warnings were included in this PR, and in the migration guide.

Deprecation warnings are removed after 10 releases, as per the policy stated at the top of the migration guide.

Repository owner deleted a comment from Benjythebee Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants