Examples: Rename GroundProjectedEnv to GroundProjectedSkybox.
#25645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
changed the title
GroundProjectedEnv to GroundProjectedSkybox.
This was referenced Apr 25, 2023
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #25287.
Description
This PR renames
GroundProjectedEnvtoGroundProjectedSkybox.As #25287 pointed out,
GroundProjectedEnvis a confusing name for the respective class since it's a 3D object derived fromMesh. You don't assign it toScene.environmentnor to anenvironmentMapmaterial property.A skybox instead is something that is usually added to a scene graph so it sounds more appropriate to use this term.
GroundProjectedBackgroundwas also suggested but I find it confusing as well since you don't assign an instance of the class toScene.background.