WebGLRenderer: convert to ES6 class #25599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
reviewed
Mar 2, 2023
Mugen87
approved these changes
Mar 3, 2023
|
Should we merge this after #25615 so we can test the new CI feature? |
|
Hmm the action worked but there has been a problem in the CI, fixed it in #25625 |
marcofugaro
changed the title
📦 Bundle size
🌳 Bundle size after tree-shakingIncludes a renderer, camera, and empty scene.
|
Maybe the action should also report an absolute value by how the size changed? I.e. not in percents but in KB. |
That'd be nice yeah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixes #25595
Description
In order to prevent the same issue in the future, I think it's safer to convert the WebGLRenderer to ES6 class as well.
This way the
physicallyCorrectLightscan be a getter/setter of the class, which doesn't break tree-shaking.