OscNode: Fix if timeNode is not a nodeObject() #25588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Mar 1, 2023
| @@ -22,7 +22,7 @@ class OscNode extends Node { | |||
| construct() { | |||
|
|
|||
| const method = this.method; | |||
| const timeNode = this.timeNode; | |||
| const timeNode = nodeObject( this.timeNode ); | |||
There was a problem hiding this comment.
Maybe we should assume that an user always passes a node object?
There was a problem hiding this comment.
I think better added it in construct() as default in case of user added a class based node like (non-nodeObject()):
new OscNode( OscNode.SINE, new CustomNode() );There was a problem hiding this comment.
Maybe we can instruct the user to always pass node objects? E.g. like oscSine( nodeObject( new CustomNode() ) )?
There was a problem hiding this comment.
Maybe we can instruct the user to always pass node objects? E.g. like oscSine( nodeObject( new CustomNode() ) )?
I think the best way would still be to standardize possible non-nodeObjects in construct() to facilitate implementation.
Anyway no object would be converted twice once we have a WeakMap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.