Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box3: Refactors setFromArray, setFromBufferAttribute #25573

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Feb 26, 2023

this PR replaces 'expand by point' logic with already existing abstraction .expandByPoint()

@mrdoob mrdoob added this to the r151 milestone Feb 27, 2023
@mrdoob mrdoob merged commit 79a55ce into mrdoob:dev Feb 27, 2023
@ycw ycw deleted the box3-setfrom branch February 28, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants