Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniformsUtils: Skip cloning textures of render targets and report warning. #25560

Merged
merged 8 commits into from
Feb 27, 2023

Conversation

simondevyoutube
Copy link
Contributor

@simondevyoutube simondevyoutube commented Feb 24, 2023

Fixed #25552.

Description

Render Target Textures can't be cloned, do a check in UniformsUtils.cloneUniforms to avoid this, and output a warning to console. Also updated docs with example usage, and unit tests.

.
.
@Mugen87 Mugen87 changed the title Skip Cloning RenderTargetTextures and Log to Console UniformUtils: Skip cloning textures of render targets and report warning. Feb 24, 2023
@Mugen87 Mugen87 changed the title UniformUtils: Skip cloning textures of render targets and report warning. UniformsUtils: Skip cloning textures of render targets and report warning. Feb 24, 2023
@Mugen87 Mugen87 added this to the r151 milestone Feb 24, 2023
@Mugen87 Mugen87 merged commit 9b396fa into mrdoob:dev Feb 27, 2023
@simondevyoutube
Copy link
Contributor Author

Hey, sorry about sitting on this, I was away from the computer for a few days! Thanks for taking this over the line.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGL Error when using UniformsUtils.merge to merge a WebGLCubeRenderTarget texture
4 participants