Editor: Rename physicallyCorrectLights to useLegacyLights
#25556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linbingquan
changed the title
physicallyCorrectLights to useLegacyLights
LeviPesin
reviewed
Feb 23, 2023
| @@ -14,7 +14,7 @@ function Config() { | |||
| 'project/renderer/antialias': true, | |||
| 'project/renderer/shadows': true, | |||
| 'project/renderer/shadowType': 1, // PCF | |||
| 'project/renderer/physicallyCorrectLights': false, | |||
| 'project/renderer/useLegacyLights': false, | |||
There was a problem hiding this comment.
I don't think we should change the default yet?
There was a problem hiding this comment.
That depends on @mrdoob preference. It could be interesting to enable physically correct lights in the editor earlier compared to the library itself.
LeviPesin
reviewed
Feb 23, 2023
|
Merging this now to remove the console warning. The value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #XXXX
Description
Rename
physicallyCorrectLightstouseLegacyLightsfor renderer to clean the browser warning.If this PR has any problem, please tell me.