Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGLoader: Gracefully handle empty paths. #25550

Merged
merged 1 commit into from
Feb 23, 2023
Merged

SVGLoader: Gracefully handle empty paths. #25550

merged 1 commit into from
Feb 23, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 22, 2023

Fixed #25548.

Description

Ensures the loader properly handles empty path definitions. From the spec:

Note that the EBNF allows the path data string in the d property to be empty. This is not an error, instead it disables rendering of the path. Rendering is also disabled when the d property has the value none.

@Mugen87 Mugen87 added this to the r150 milestone Feb 22, 2023
@mrdoob mrdoob merged commit 0926a67 into mrdoob:dev Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVGLoader fails on empty paths
2 participants