enable camera view offset in CSS3DRenderer #25508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yomotsu
commented
Feb 14, 2023
| const viewElement = document.createElement( 'div' ); | ||
| viewElement.style.transformOrigin = '0 0'; | ||
| viewElement.style.pointerEvents = 'none'; | ||
| domElement.appendChild( viewElement ); |
There was a problem hiding this comment.
As I mentioned #21723 (comment)
a wrapper element is required to handle camera-view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #21723
Description
Currently, CSS3DRenderer ignores
camera.setViewOffset().This PR is for enabling camera's viewOffset in CSS3DRenderer for both PerspectiveCamera and OrthographicCamera.
Also, I added viewOffset controls into:
p.mp4
o.mp4