Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeEditor: Update Flow.js lib and added TreeView to create Node #25500

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Feb 14, 2023

Description

TreeView

This PR is in line with others that I am finalizing. ContextMenu is not a very appropriate Menu for large content options, in that sense I created a TreeView where we could also search for Nodes by a filter field.

Live:
https://raw.githack.com/mrdoob/three.js/dev/examples/webgl_nodes_playground.html

image

@sunag sunag added this to the r150 milestone Feb 14, 2023
@LeviPesin
Copy link
Contributor

LeviPesin commented Feb 14, 2023

Something strange is going on with the checks on this PR... They are running for about 4 hours, still did not finished, and this doesn't allow to run queued CI checks on other PRs and they stale.

@sunag sunag marked this pull request as ready for review February 14, 2023 20:48
@sunag sunag merged commit f10a59a into mrdoob:dev Feb 15, 2023
@sunag sunag added the Nodes label Feb 17, 2023
@sunag sunag deleted the dev-node-editor branch February 17, 2023 17:32
@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 31, 2023

Nit: There are two places were superfluous arguments are passed to a super() call:

class ContextMenu extends Menu {
constructor( target = null ) {
super( 'context', target );

and

class CircleMenu extends Menu {
constructor( target = null ) {
super( 'circle', target );

Probably best to fix this in the main repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants