-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodes: Rework ShaderNodeElements and make some other refactorings #25498
Conversation
@LeviPesin Awesome! It just broke |
I think we can move nodeLib and fromType to a separate file and this should resolve the issue... Will do that. |
…Pesin/three.js-1 into refactor-shadernodeelements
Done! |
@LeviPesin We should give the option to expand the serialization, |
Agreed! And same for materials. |
…ghtNode, add addNodeClass and addNodeMaterial
…Pesin/three.js-1 into refactor-shadernodeelements
Done!
|
@mrdoob do you have some suggestion about this #25498 (comment)? I'm thinking of merge and we deciding these definitions soon. |
Modifications are more internal, so not affect the external API (examples/projects) or very little. Merging... |
Fixes #25240, partially fixes #23666
Implements #25240 (comment) and #25240 (comment)
Description
Changes:
three/nodes
,addNodeElement
/addLightNode
/addNodeClass
/addNodeMaterial
functions,Tested all examples -- they seem to work.