DRACOLoader: Update Draco decoders to v1.5.6 #25475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
added
Loaders
Dependencies
This was referenced Feb 9, 2023
|
Quick question on what is public API; are the following public ? decodeDracoFile( buffer, callback, attributeIDs, attributeTypes, vertexColorSpace = LinearSRGBColorSpace )
decodeGeometry( buffer, taskConfig )
debug()Looks like no public API changes but, checking the doc all the same, and these popped out as possible additions. |
|
I'd prefer to consider those internal APIs, no need to document them for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that DRACOLoader now uses Draco APIs that weren't available in earlier versions of the Draco library. Users upgrading to the latest THREE.DRACOLoader will also need to update the decoders.