Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Remove special case for normalized skin weights #25469

Merged

Conversation

donmccurdy
Copy link
Collaborator

Related:

GLTFLoader currently normalizes skin weights only for float32 skinWeight attributes, because SkinnedMesh.normalizeSkinWeights previously didn't support normalized vertex attributes. With recent changes (#22874) it now does, so we don't need that exception.

@donmccurdy donmccurdy added this to the r150 milestone Feb 8, 2023
@mrdoob mrdoob merged commit 13a4fe1 into mrdoob:dev Feb 9, 2023
@donmccurdy donmccurdy deleted the hotfix/gltfloader-normalized-skin-weights branch February 9, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants