-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OrbitControls: Add stopListenToKeyEvents()
.
#25418
Conversation
If I called listenToKeyEvents(), sometimes I want to remove this event listener, temporary or otherwise.
Fix DOM element reference.
unlistenToKeyEvents()
.
"unlisten" is not a word. Is there a better API? 🤔 Also, maybe set |
from https://ell.stackexchange.com/questions/214085/is-there-any-word-for-unlisten-negative-of-listen
TBH, I feel very strong about this statement. |
Good catch! I'll update the PR. |
That's fine. But if you are using "unlisten" to mean "stop listening", then use That's both correct and clear. Or |
How about |
Oh yes. (That was a typo.) |
unlistenToKeyEvents()
.stopListenToKeyEvents()
.
Can we make it a word? 😅 How about listenKeyEvents()
ignoreKeyEvents() I don't like that "To" in the name... 😕 |
The I'm okay with the shorter version as well :) |
If I called listenToKeyEvents(), sometimes I want to remove this event listener, temporarily or otherwise.