Tests: Post Update Review #25417
Merged
Tests: Post Update Review #25417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Qunit hooks to provision and cleanup global mocks.
Use Qunit hooks to provision and cleanup global mocks.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Format code for clearer error messages.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
LeviPesin
reviewed
Feb 2, 2023
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
Explicit block scope for variables used in supporting test code.
review
|
I've made a bunch of notes. One on this topic is about moving to vite / vitest. I'm sure you understand the benefits. Happy to reformat the tests in jest / vitest compatible units. The recent changes in the build and dropping babel (to let the final app bundler do the translation) means that this project nearly has a default vite config for a lib. Its fast, nice to have live test feedback as you develop (unit tests, preview, type checking, linting, vscode integration). Might pare nicely with the e2e puppeteer stuff. I'm not sure where these conversations happen. I've got a list of notes, questions, options. Not too fixed on any one direction except for filling in these unit tests while updating the documentation. Point me where to write them out. |
|
Maybe you can create a new issue and write them there? |
|
@mrdoob I'd like to get back to filling in tests. Is there anything I can do to break this up for review ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests to make them more consistent. Use Qunit hooks to provision and cleanup global mocks in Audio. Explicit block scope for variables used in tests.