Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Remove IIFE closures #25416

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented Feb 2, 2023

Related comment: #25377 (review)

Description

This PR removes IIFE closures in loadNode() and loadNodeShallow() in GLTFLoader because they don't look like really necessary.

They seem to have been originally introduced at some point for a certain reason but I couldn't track. Perhaps outdated.

This commit removes IIFE closures in loadNode() and
loadNodeShallow() in GLTFLoader because they don't look like
really necessary.
@takahirox takahirox force-pushed the GLTFLoaderRemoveClosure branch from b4789a3 to 955c13d Compare February 2, 2023 17:04
@takahirox takahirox requested a review from donmccurdy February 2, 2023 17:04
@mrdoob mrdoob added this to the r150 milestone Feb 3, 2023
@mrdoob mrdoob merged commit 0bc5d61 into mrdoob:dev Feb 3, 2023
@takahirox takahirox deleted the GLTFLoaderRemoveClosure branch February 3, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants