Tests: Unit Tests for Animation #25409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit block scope for variables used in tests. Stub missing member tests.
AnimationClip can be instanciated AnimationClip can be named Stub missing member tests.
AnimationMixer extends from EventDispatcher Stub missing member tests.
AnimationObjectGroup can be instanciated AnimationObjectGroup.isAnimationObjectGroup should be true Explicit block scope for variables used in tests. Stub missing member tests.
Stub missing member tests.
Stub missing member tests.
Explicit block scope for variables used in tests.
Stub missing member tests.
BooleanKeyframeTrack extends from KeyframeTrack
ColorKeyframeTrack extends from KeyframeTrack
NumberKeyframeTrack extends from KeyframeTrack
QuaternionKeyframeTrack extends from KeyframeTrack
StringKeyframeTrack extends from KeyframeTrack
VectorKeyframeTrack extends from KeyframeTrack
Separate the first import to clearly mark the test subject.
Explicit block scope for variables used in tests.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Split setEffectiveWeight into 3 functional tests and resolve the variable block scope issue at the same time. At the moment, trying to minimize changes to working tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests for Animation.
Fills in some unit tests, populates the missing member tests with stubs. Explicit block scope for variables used in tests.