Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Unit Tests for Audio #25406

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Tests: Unit Tests for Audio #25406

merged 5 commits into from
Feb 2, 2023

Conversation

epreston
Copy link
Contributor

@epreston epreston commented Feb 2, 2023

Related issue: none.

Description

This cleans up the unit tests for Audio.
Fills in some unit tests, populates the missing member tests with stubs.

Mock listener.
Audio extends from Object3D
Audio.type should be Audio
Stub missing member tests.
Stub missing member tests.
AudioContext.getContext creates a context.
AudioContext.setContext updates the context.
AudioListener extends from Object3D
AudioListener.type should be AudioListener
Stub missing member tests.
PositionalAudio extends from Audio.
Stub missing member tests.
@mrdoob mrdoob added this to the r150 milestone Feb 2, 2023
@mrdoob mrdoob merged commit 98c6b66 into mrdoob:dev Feb 2, 2023
@epreston epreston deleted the tests-audio-cleanup branch February 2, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants