Tests: Unit Tests for Cameras #25404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArrayCamera extends from PerspectiveCamera ArrayCamera.isArrayCamera should be true Stub missing member test.
Camera extends from Object3D Camera.isCamera should be true Explicit block scope for variables used in tests. Stub missing member tests.
CubeCamera extends from Object3D CubeCamera.type should be CubeCamera Stub missing member tests.
OrthographicCamera extends from Camera OrthographicCamera.type should be OrthographicCamera OrthographicCamera.isOrthographicCamera should be true Explicit block scope for variables used in tests. Stub missing member tests.
Tone down previous comments.
PerspectiveCamera extends from Camera PerspectiveCamera.type should be PerspectiveCamera PerspectiveCamera.isPerspectiveCamera should be true Explicit block scope for variables used in tests. Stub missing member tests.
StereoCamera.type should be StereoCamera Stub missing member tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests for Cameras.
Fills in some unit tests, populates the missing member tests with stubs. Explicit block scope for variables used in tests.