Tests: Unit Tests for Core #25402
Merged
Tests: Unit Tests for Core #25402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UniformsGroup extends from EventDispatcher UniformsGroup.isUniformsGroup should be true
GLBufferAttribute.isGLBufferAttribute should be true
Object3D extends from EventDispatcher Stub missing member tests. Explicit block scope for variables used in tests.
BufferAttribute.isBufferAttribute should be true Stub missing member tests. Explicit block scope for variables used in tests. Int8BufferAttribute extends from BufferAttribute Uint8BufferAttribute extends from BufferAttribute Uint8ClampedBufferAttribute extends from BufferAttribute Int16BufferAttribute extends from BufferAttribute Uint16BufferAttribute extends from BufferAttribute Int32BufferAttribute extends from BufferAttribute Uint32BufferAttribute extends from BufferAttribute Float16BufferAttribute extends from BufferAttribute Float32BufferAttribute extends from BufferAttribute Float64BufferAttribute extends from BufferAttribute
BufferGeometry extends from EventDispatcher BufferGeometry.type should be BufferGeometry Stub missing member tests. Explicit block scope for variables used in tests.
Stub missing member tests. Explicit block scope for variables used in tests.
Explicit block scope for variables used in tests.
BufferAttribute extends from BufferAttribute InstancedBufferAttribute.isInstancedBufferAttribute should be true Explicit block scope for variables used in tests. Stub missing member tests.
InstancedBufferGeometry extends from BufferGeometry InstancedBufferGeometry.type should be InstancedBufferGeometry InstancedBufferGeometry.isInstancedBufferGeometry should be true Explicit block scope for variables used in tests. Stub missing member tests.
InstancedInterleavedBuffer extends from InterleavedBuffer InstancedInterleavedBuffer.isInstancedInterleavedBuffer should be true Explicit block scope for variables used in tests. Stub missing member tests.
InterleavedBuffer.isInterleavedBuffer should be true Stub missing member tests. Explicit block scope for variables used in tests.
InterleavedBufferAttribute.isInterleavedBufferAttribute should be true Explicit block scope for variables used in tests. Stub missing member tests.
Explicit block scope for variables used in tests. Stub missing member tests.
Explicit block scope for variables used in tests. Stub missing member tests.
Explicit block scope for variables used in tests. Stub missing member test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests for Core.
Adds missing unit test files, fills in some unit tests, populates the missing member tests with stubs. Explicit block scope for variables used in tests.