Tests: Unit Tests for Extras #25401
Merged
Tests: Unit Tests for Extras #25401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stub Earcut unit tests.
Stub ImageUtils unit tests.
Stub PMREMGenerator unit tests.
review.
review.
Curve.type should be Curve Stub missing member tests.
CurvePath extends from Curve Curve.type should be Curve Stub missing member tests. Remove tests for members that don't exist in source.
Path extends from CurvePath Path.type should be Path Stub missing member tests.
Shape extends from Path Shape.type should be Shape Stub missing member tests.
ShapePath.type should be ShapePath Stub missing member tests.
CatmullRomCurve3 extends from Curve CatmullRomCurve3.type should be CatmullRomCurve3 CatmullRomCurve3.isCatmullRomCurve3 should be true Stub missing member tests.
ArcCurve extends from EllipseCurve ArcCurve.type should be ArcCurve ArcCurve.isArcCurve should be true
CubicBezierCurve extends from Curve CubicBezierCurve.type should be CubicBezierCurve CubicBezierCurve.isCubicBezierCurve should be true Stub missing member tests.
CubicBezierCurve3 extends from Curve CubicBezierCurve3.type should be CubicBezierCurve3 CubicBezierCurve3.isCubicBezierCurve3 should be true Stub missing member tests.
EllipseCurve extends from Curve EllipseCurve.type should be EllipseCurve EllipseCurve.isEllipseCurve should be true Stub missing member tests.
LineCurve extends from Curve LineCurve.type should be LineCurve LineCurve.isLineCurve should be true Stub missing member tests.
LineCurve3 extends from Curve LineCurve3.type should be LineCurve3 LineCurve3.isLineCurve3 should be true Stub missing member tests.
QuadraticBezierCurve extends from Curve QuadraticBezierCurve.type should be QuadraticBezierCurve QuadraticBezierCurve.isQuadraticBezierCurve should be true Stub missing member tests.
QuadraticBezierCurve3 extends from Curve QuadraticBezierCurve3.type should be QuadraticBezierCurve3 QuadraticBezierCurve3.isQuadraticBezierCurve3 should be true Stub missing member tests.
SplineCurve extends from Curve SplineCurve.type should be SplineCurve SplineCurve.isSplineCurve should be true Stub missing member tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests for Extras.
Adds missing unit test files, fills in some unit tests, populates the missing member tests with stubs.