Tests: Unit Tests for Geometries #25399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoxGeometry extends from BufferGeometry BoxGeometry.type should be BoxGeometry Stub missing member tests.
CapsuleGeometry extends from LatheGeometry CapsuleGeometry.type should be CapsuleGeometry Stub missing member tests.
CircleGeometry extends from BufferGeometry CircleGeometry.type should be CircleGeometry Stub missing member tests.
ConeGeometry extends from CylinderGeometry. ConeGeometry.type should be ConeGeometry Stub missing member tests.
CylinderGeometry extends from BufferGeometry CylinderGeometry.type should be CylinderGeometry Stub missing member tests.
DodecahedronGeometry extends from PolyhedronGeometry DodecahedronGeometry.type should be DodecahedronGeometry Stub missing member tests.
EdgesGeometry extends from BufferGeometry EdgesGeometry.type should be EdgesGeometry Stub missing member tests. Explicit block scope for variables used in tests.
ExtrudeGeometry extends from BufferGeometry ExtrudeGeometry.type should be ExtrudeGeometry Stub missing member tests.
IcosahedronGeometry extends from PolyhedronGeometry IcosahedronGeometry.type should be IcosahedronGeometry Stub missing member tests.
LatheGeometry extends from BufferGeometry LatheGeometry.type should be LatheGeometry Stub missing member tests.
OctahedronGeometry extends from PolyhedronGeometry OctahedronGeometry.type should be OctahedronGeometry Stub missing member tests.
PlaneGeometry extends from BufferGeometry PlaneGeometry.type should be PlaneGeometry Stub missing member tests.
PolyhedronGeometry extends from BufferGeometry PolyhedronGeometry.type should be PolyhedronGeometry Stub missing member tests.
RingGeometry extends from BufferGeometry RingGeometry.type should be RingGeometry Stub missing member tests.
ShapeGeometry extends from BufferGeometry ShapeGeometry.type should be ShapeGeometry Stub missing member tests.
SphereGeometry extends from BufferGeometry SphereGeometry.type should be SphereGeometry Stub missing member tests.
TetrahedronGeometry extends from PolyhedronGeometry TetrahedronGeometry.type should be TetrahedronGeometry Stub missing member tests.
TorusGeometry extends from BufferGeometry TorusGeometry.type should be TorusGeometry Stub missing member tests.
TorusKnotGeometry extends from BufferGeometry TorusKnotGeometry.type should be TorusKnotGeometry Stub missing member tests.
TubeGeometry extends from BufferGeometry TubeGeometry.type should be TubeGeometry Stub missing member tests.
WireframeGeometry extends from BufferGeometry WireframeGeometry.type should be WireframeGeometry Stub missing member tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests for Geometries.
Fills in some unit tests, populates the missing member tests with stubs. Explicit block scope for variables used in tests.