Tests: Unit Tests for Lights #25393
Merged
Tests: Unit Tests for Lights #25393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmbientLight extends from Light. AmbientLight.type should be AmbientLight. AmbientLight.isAmbientLight should be true. Correct module name.
Add AmbientLightProbe unit tests. AmbientLightProbe extends from LightProbe. AmbientLightProbe.isAmbientLightProbe should be true
DirectionalLight extends from Light. DirectionalLight.type should be DirectionalLight. DirectionalLight.isDirectionalLight should be true. Stub missing member tests.
DirectionalLightShadow extends from LightShadow. DirectionalLightShadow.isDirectionalLightShadow should be true.
HemisphereLight extends from Light. HemisphereLight.type should be HemisphereLight. HemisphereLight.isHemisphereLight should be true.
Add HemisphereLightProbe unit tests. HemisphereLightProbe extends from LightProbe. HemisphereLightProbe.isHemisphereLightProbe should be true.
Light extends from Object3D. Light.isLight should be true. Stub missing member tests.
Add LightProbe unit tests. LightProbe extends from Light. LightProbe.isLightProbe should be true.
Stub missing member tests.
PointLight extends from Light. PointLight.type should be PointLight. PointLight.isPointLight should be true. Stub missing member tests.
Add PointLightShadow unit tests. PointLightShadow extends from LightShadow. PointLightShadow.isPointLightShadow should be true.
SpotLightShadow extends from LightShadow. SpotLightShadow.isSpotLightShadow should be true. Stub missing member test.
SpotLight extends from Light. SpotLight.type should be SpotLight. SpotLight.isSpotLight should be true. Stub missing member tests.
RectAreaLight extends from Light. RectAreaLight.type should be RectAreaLight. RectAreaLight.isRectAreaLight should be true. Add power / Intensity tests.
Make tests more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests for Lights.
Adds missing unit test files, fills in some unit tests, populates the missing member tests with stubs. Explicit block scope for variables used in tests.