Tests: Unit Tests for Loaders #25391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ImageBitmapLoader unit tests.
Loader defines a default manager if not supplied in constructor. Loader defines crossOrigin. Loader defines withCredentials. Loader defines path. Loader defines resourcePath. Loader defines requestHeader. Stub missing member tests.
AnimationLoader extends from Loader.
AudioLoader extends from Loader.
BufferGeometryLoader extends from Loader.
Cache defines enabled. Cache defines files.
CompressedTextureLoader extends from Loader. Remove test for base class method which is not redfined in this class.
CubeTextureLoader extends from Loader. Remove test for base class method which is not redfined in this class.
DataTextureLoader extends from Loader.
FileLoader extends from Loader. Remove tests for base class methods which are not redfined in this class.
ImageLoader extends from Loader. Remove tests for base class methods which are not redfined in this class.
Stub missing member test.
Stub missing member tests.
MaterialLoader extends from Loader. MaterialLoader defines textures. Stub missing member test.
ObjectLoader extends from Loader. Stub missing member tests. Remove tests for base class methods which are not redfined in this class.
TextureLoader extends from Loader. Remove tests for base class methods which are not redfined in this class.
|
Not getting any hearts lately. haha ;-) |
|
Ops! Fixed 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests for Loaders.
Adds missing unit test file, fills in some unit tests, populates the missing member tests with stubs. Removes tests for base class methods which are not redfined in the child class.