DRACOLoader, DRACOExporter: Convert vertex colors to/from Linear-sRGB #25390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
donmccurdy
changed the title
donmccurdy
force-pushed
the
hotfix/dracoloader-dracoexporter-vertex-colorspace
branch
from
f644165 to
81b27db
Compare
donmccurdy
deleted the
hotfix/dracoloader-dracoexporter-vertex-colorspace
branch
donmccurdy
changed the title
donmccurdy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
While .drc files do not specify colorspace, the only 'official' tooling is the Draco library's PLY and OBJ converters, which use sRGB. We'll assume sRGB is expected for .drc files, but note that Draco buffers embedded in glTF files will be Linear-sRGB instead. This change ensures that when using the .load() or .parse() methods of DRACOLoader, we use the appropriate color spaces for .drc files. GLTFLoader uses an internal API instead and will not be affected.