-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Unit Tests for Materials #25388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MeshMatcapMaterial unit test.
LineDashedMaterial extends from Material LineDashedMaterial.type should be LineDashedMaterial LineDashedMaterial.isLineDashedMaterial should be true Stub missing member tests.
LineBasicMaterial extends from Material LineBasicMaterial.type should be LineBasicMaterial. LineBasicMaterial.isLineBasicMaterial should be true Stub missing member tests.
Material extends from EventDispatcher. Material.type should be Material. Material.isMaterial should be true. Stub missing member tests.
MeshBasicMaterial extends from Material. MeshBasicMaterial.type should be MeshBasicMaterial. MeshBasicMaterial.isMeshBasicMaterial should be true Stub missing member tests.
MeshDepthMaterial extends from Material. MeshDepthMaterial.type should be MeshDepthMaterial. MeshDepthMaterial.isMeshDepthMaterial should be true. Stub missing member tests.
MeshDistanceMaterial extends from Material. MeshDistanceMaterial.type should be MeshDistanceMaterial. MeshDistanceMaterial.isMeshDistanceMaterial should be true. Stub missing member tests.
MeshLambertMaterial extends from Material. MeshLambertMaterial.type should be MeshLambertMaterial. MeshLambertMaterial.isMeshLambertMaterial should be true. Stub missing member tests.
MeshNormalMaterial extends from Material. MeshNormalMaterial.type should be MeshNormalMaterial. MeshNormalMaterial.isMeshNormalMaterial should be true. Stub missing member tests.
MeshPhongMaterial extends from Material. MeshPhongMaterial.type should be MeshPhongMaterial. MeshPhongMaterial.isMeshPhongMaterial should be true. Stub missing member tests.
MeshPhysicalMaterial extends from Material. MeshPhysicalMaterial.type should be MeshPhysicalMaterial. MeshPhysicalMaterial.isMeshPhysicalMaterial should be true. Stub missing member tests.
MeshStandardMaterial extends from Material. MeshStandardMaterial.type should be MeshStandardMaterial. MeshStandardMaterial.isMeshStandardMaterial should be true. Stub missing member tests.
MeshToonMaterial extends from Material. MeshToonMaterial.type should be MeshToonMaterial. MeshToonMaterial.isMeshToonMaterial should be true. Stub missing member tests.
PointsMaterial extends from Material. PointsMaterial.type should be PointsMaterial. PointsMaterial.isPointsMaterial should be true. Stub missing member tests.
RawShaderMaterial extends from ShaderMaterial. RawShaderMaterial.type should be RawShaderMaterial. RawShaderMaterial.isRawShaderMaterial should be true.
ShaderMaterial extends from Material. ShaderMaterial.type should be ShaderMaterial. ShaderMaterial.isShaderMaterial should be true. Stub missing member tests.
ShadowMaterial extends from Material. ShadowMaterial.type should be ShadowMaterial. ShadowMaterial.isShadowMaterial should be true. Stub missing member tests.
SpriteMaterial extends from Material. SpriteMaterial.type should be SpriteMaterial. SpriteMaterial.isSpriteMaterial should be true. Stub missing member tests.
Mugen87
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests for Materials.
Adds missing unit test file, fills in some unit tests, populates the missing member tests with stubs.