Puppeteer E2E test: Run on multiple OSes #25383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you exaplain what is the purpose of this PR? Why does the E2E testing need to run on different os? |
|
Since when working on #24109 I found that quite often (about 10% of all examples) they work differently (producing different screenshots or even different errors in some cases) on different OSes. |
|
Ah ok so it's to test if some example looks different on another OS. Is this necessary for three.js? |
|
I had an example comparison here: #24109 (comment) |
|
@LeviPesin e2e tests are running very smooth on Win10 and OSX (apple silicon) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24109
Description
Make Puppeteer test examples on different OSes (Windows, Ubuntu, and Mac). Also reduced the number of threads from 8 to 6 to reduce the number of jobs (I will file a PR for multi-page in-browser parallelism soon, which wouldn't require multi-threading anymore -- but it is quite unstable)