Puppeteer E2E test: Auto-download browser #25380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated question: where do I set the global timeout on the e2e tests ? |
|
What is the "global timeout"? You should either increase |
|
It takes only around 10 seconds to download chrome on github actions, not bad!
|
|
Ops... Some conflicts to resolve... |
|
It's conflicting with #25384, I think... |
|
I deleted |
|
@mrdoob I think I resolved the conflicts. |
Merged
mrdoob
pushed a commit
that referenced
this pull request
Feb 2, 2023
Qunit node module now found in base since PR #25380
mrdoob
pushed a commit
that referenced
this pull request
Feb 7, 2023
* Update Unit Test Readme Update unit test readme to reflect changes since #25380 Avoid building the library and flagging the files as changed (tests run off source) Add notes to help people running unit tests. ColorManagement.enabled is false by default. Tune logging so only genuine test failure messages are displayed. * Update ColorManagement.tests.js Minimize the console messages captured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24109
Description
Make Puppeteer auto-download latest Chromium browser and merge
test/package.jsonwith the corepackage.json(they were splitted becausepuppeteerpackage is very large -- nowpuppeteer-corepackage is used and the browser is downloaded by the script).