Tests: Unit Tests for Objects #25378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bone.isBone should be true.
Group.type should be Group. Group.isGroup should be true.
Bone.type should be Bone
Add unit tests for InstancedMesh
Line.type should be Line. Line.isLine should be true. Add missing member test stubs.
LineLoop.type should be LineLoop LineLoop.isLineLoop should be true Add missing member test stubs.
LineSegments.type should be LineSegments LineSegments.isLineSegments should be true Add missing member test stubs.
LOD.type should be LOD Add missing member test stubs.
Mesh.type should be Mesh. Mesh.isMesh should be true. Add missing member test stubs. Clone is defined by parent class and not redefined here.
Points.type should be Points. Points.isPoints should be true. Add missing member test stubs. Clone is defined by parent class and not redefined here.
Add missing member test stubs.
SkinnedMesh.type should be SkinnedMesh. SkinnedMesh.bindMode should be attached. SkinnedMesh.isSkinnedMesh should be true. Add missing member test stubs. Clone is defined by a parent class and not redefined here.
Sprite.type should be Sprite. Sprite.isSprite should be true. Add missing member test stubs. Clone is defined by parent class and not redefined here.
Add InstancedMesh to list of unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none.
Description
This cleans up the unit tests for Objects.
Adds missing unit test file, fills in some unit tests, populates the missing member tests with stubs.