Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: Consider marking event handler as 'passive' to make the page more responsive #25374

Merged
merged 5 commits into from
Jan 31, 2023
Merged

fixed: Consider marking event handler as 'passive' to make the page more responsive #25374

merged 5 commits into from
Jan 31, 2023

Conversation

puxiao
Copy link
Contributor

@puxiao puxiao commented Jan 30, 2023

Description

https://threejs.org/editor/

in Chrome - Console :

[Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive. See <URL>

The reason for this is the same as #21642

@mrdoob mrdoob added this to the r150 milestone Jan 31, 2023
@mrdoob mrdoob merged commit ab77220 into mrdoob:dev Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r150
Development

Successfully merging this pull request may close these issues.
2 participants
@puxiao @mrdoob