-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Unit Tests for Textures #25365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit test file for textures/FramebufferTexture
Add missing properties and describe how they differ from the base class, Texture.
Add example code, link to full example, add property that differs from base class.
DepthTexture extends from Texture
FramebufferTexture extends from Texture
CanvasTexture extends from Texture
Add missing property test stubs.
CompressedTexture extends from Texture
Add missing property test stubs.
Add missing unit test file, one complete test to show its working, stubs for members.
CubeTexture extends from Texture
Add missing unit test file, one complete test to show its working, stubs for members.
Add missing unit test file, one complete test to show its working, stubs for members.
Link to added unit tests.
DataTexture extends from Texture
Texture extends from EventDispatcher. Add missing property and method test stubs.
VideoTexture extends from Texture. Add missing properties and method test stubs.
Separate INHERITANCE and INSTANCING tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: none
Description
Following the second pull request to nail down the process, this cleans up the unit tests for Textures.
It fills in one working unit test for each (up from 0) and populates the missing member tests with stubs.