Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: stub textures/Source unit tests #25361

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Tests: stub textures/Source unit tests #25361

merged 2 commits into from
Jan 29, 2023

Conversation

epreston
Copy link
Contributor

Related issue: none.

Description

Add unit test file for textures/Source.
Add missing property to docs.

Add unit test file for textures/Source
Add missing property.
@Mugen87 Mugen87 added this to the r150 milestone Jan 29, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 29, 2023

Merging, although it is not necessary to create PRs for missing stubs in context of the unit tests.

IMO, the stubs should never have been added in the first place. Unit tests only create a value if they are properly implemented.

@Mugen87 Mugen87 merged commit db859f1 into mrdoob:dev Jan 29, 2023
@epreston
Copy link
Contributor Author

@Mugen87 fully agree. I've started to fill unit tests in while matching up documentation. Stubs are to keep me organised until I get into a rhythm. One more pull request of stubs, nail down the process, and it's populated unit tests here on out.

@epreston epreston deleted the tests-textures-source branch January 29, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants