Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Puppeteer to 19.4.0 (Chromium 109.0.5412.0) #25313

Merged
merged 4 commits into from
Jan 21, 2023
Merged

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Jan 20, 2023

Related issue: #25304

@LeviPesin
Copy link
Contributor

I think you forgot to update package-lock.json...

@mrdoob
Copy link
Owner Author

mrdoob commented Jan 20, 2023

Uh...

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-node@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

The save-state command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@mrdoob
Copy link
Owner Author

mrdoob commented Jan 20, 2023

grep "actions/setup-node" * -r
node_modules/jpeg-js/.github/workflows/ci.yml:      - uses: actions/setup-node@v1
node_modules/timm/.github/workflows/run-tests.yml:        uses: actions/setup-node@v1

@mrdoob mrdoob added this to the r149 milestone Jan 21, 2023
@mrdoob mrdoob merged commit c6c98d8 into dev Jan 21, 2023
@mrdoob mrdoob deleted the mrdoob-patch-1 branch January 21, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants